Build 060.20.2: integrate Consistency with Trade Runtime

app/tests/unit/market_data/acquisition/consistency/test_trade_stream_consistency_controller.py

@@ -14,10 +14,30 @@ from src.market_data.acquisition.consistency.trade_stream_exceptions import (
     TradeConsistencyError,
     TradeOrderingError,
 )
+from src.market_data.acquisition.consistency.trade_stream_state import (
+    TradeStreamState,
+)
 from src.market_data.acquisition.models.trade import (
     Trade,
     TradeAggressorSide,
 )
+from src.market_data.acquisition.runtime.trade.trade_runtime_registry import (
+    TradeRuntimeRegistry,
+)
+
+
+@pytest.fixture
+def runtime() -> TradeRuntimeRegistry:
+    return TradeRuntimeRegistry()
+
+
+@pytest.fixture
+def controller(
+    runtime: TradeRuntimeRegistry,
+) -> TradeStreamConsistencyController:
+    return TradeStreamConsistencyController(
+        runtime=runtime,
+    )
 
 
 def _trade(
@@ -46,19 +66,35 @@ def _trade(
     )
 
 
-def test_creates_state_for_first_symbol() -> None:
-    controller = TradeStreamConsistencyController()
-
+def test_creates_state_for_first_symbol(
+    controller: TradeStreamConsistencyController,
+    runtime: TradeRuntimeRegistry,
+) -> None:
     trade = _trade(symbol="BTCUSD")
 
     result = controller.accept(trade)
 
     assert result == trade
+    assert runtime.is_registered("consistency:BTCUSD")
 
 
-def test_reuses_state_for_same_symbol() -> None:
-    controller = TradeStreamConsistencyController()
+def test_registers_trade_stream_state(
+    controller: TradeStreamConsistencyController,
+    runtime: TradeRuntimeRegistry,
+) -> None:
+    controller.accept(
+        _trade(symbol="BTCUSD"),
+    )
 
+    state = runtime.get("consistency:BTCUSD")
+
+    assert isinstance(state, TradeStreamState)
+
+
+def test_reuses_state_for_same_symbol(
+    controller: TradeStreamConsistencyController,
+    runtime: TradeRuntimeRegistry,
+) -> None:
     first_trade = _trade(
         symbol="BTCUSD",
         trade_id=100,
@@ -69,15 +105,19 @@ def test_reuses_state_for_same_symbol() -> None:
     )
 
     controller.accept(first_trade)
+    first_state = runtime.get("consistency:BTCUSD")
 
     result = controller.accept(second_trade)
+    second_state = runtime.get("consistency:BTCUSD")
 
     assert result == second_trade
+    assert second_state is first_state
 
 
-def test_keeps_independent_state_per_symbol() -> None:
-    controller = TradeStreamConsistencyController()
-
+def test_keeps_independent_state_per_symbol(
+    controller: TradeStreamConsistencyController,
+    runtime: TradeRuntimeRegistry,
+) -> None:
     btc_trade = _trade(
         symbol="BTCUSD",
         trade_id=100,
@@ -90,13 +130,17 @@ def test_keeps_independent_state_per_symbol() -> None:
     btc_result = controller.accept(btc_trade)
     eth_result = controller.accept(eth_trade)
 
+    btc_state = runtime.get("consistency:BTCUSD")
+    eth_state = runtime.get("consistency:ETHUSD")
+
     assert btc_result == btc_trade
     assert eth_result == eth_trade
+    assert btc_state is not eth_state
 
 
-def test_returns_none_for_duplicate_trade() -> None:
-    controller = TradeStreamConsistencyController()
-
+def test_returns_none_for_duplicate_trade(
+    controller: TradeStreamConsistencyController,
+) -> None:
     trade = _trade()
 
     controller.accept(trade)
@@ -106,9 +150,9 @@ def test_returns_none_for_duplicate_trade() -> None:
     assert result is None
 
 
-def test_propagates_ordering_error() -> None:
-    controller = TradeStreamConsistencyController()
-
+def test_propagates_ordering_error(
+    controller: TradeStreamConsistencyController,
+) -> None:
     controller.accept(
         _trade(trade_id=100),
     )
@@ -119,9 +163,9 @@ def test_propagates_ordering_error() -> None:
         )
 
 
-def test_propagates_consistency_error() -> None:
-    controller = TradeStreamConsistencyController()
-
+def test_propagates_consistency_error(
+    controller: TradeStreamConsistencyController,
+) -> None:
     controller.accept(
         _trade(
             trade_id=100,